search

denoland / deno_core

The core engine at the heart of Deno
MIT License
286 stars 94 forks source link

op2 error #834

Closed misobarisic closed 3 months ago

misobarisic commented 3 months ago

I am having trouble using deno_core as a dependency since I am constantly getting this error


error[E0282]: type annotations needed
    --> /home/mb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.296.0/ops_builtin_v8.rs:1172:1
     |
1172 | #[op2]
     | ^^^^^^ cannot infer type
     |
     = note: this error originates in the attribute macro `op2` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
    --> /home/mb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.296.0/ops_builtin_v8.rs:1187:1
     |
1187 | #[op2]
     | ^^^^^^
     | |
     | expected `Local<'_, External>`, found `Local<'_, Value>`
     | arguments to this function are incorrect
     |
     = note: expected struct `Local<'_, External>`
                found struct `Local<'_, v8::Value>`
bartlomieju commented 3 months ago

Which version of Rust are you using?

bartlomieju commented 3 months ago

Actually, it's because of changes in latest rusty_v8. I'm opening a PR to update to these changes in a moment.