denoland / deno_docker

Latest dockerfiles and images for Deno - alpine, centos, debian, ubuntu
https://hub.docker.com/r/denoland/deno
MIT License
883 stars 101 forks source link

Document tini #299

Open benatkin opened 1 year ago

benatkin commented 1 year ago

Unlike the official images for python and node, Deno's docker images bundle tini. This seems to be a good idea, but it doesn't say in the README why it uses tini and others don't. I think it's because other runtimes let the devs deal with the mess that having no init and having no signal handling creates, while Deno helps by adding tini.

Perhaps Deno could make it so tini (or docker run --init) is presented less as the only way to run it, because the signal API was made stable (February 17, 2022) after tini was added to the Dockerfile(Aug 23, 2021).

dojyorin commented 10 months ago

I also agree with using Docker built-in tini. I think contents of container image should be simple.

benatkin commented 10 months ago

Also the Docker image from which it pulls tini, buildpack-deps, doesn't mention tini in its README

dojyorin commented 10 months ago

Although experimental I created simple and clean dockerfile for alpine and distroless. Synced daily with original deno and automatically pushed to DockerHub. If works fine, I consider making pull request to this repository.