denoland / deno_emit

Transpile and bundle JavaScript and TypeScript under Deno and Deno Deploy
https://jsr.io/@deno/emit
MIT License
223 stars 23 forks source link

Should `deno_emit` output ignore comments like `deno bundle`? #106

Open yacinehmito opened 1 year ago

yacinehmito commented 1 year ago

I am in the process of back-porting tests from deno bundle to deno_emit, and I found that we explicitly ensure that the output of deno bundle contains the following:

// deno-fmt-ignore-file
// deno-lint-ignore-file
// This code was bundled using `deno bundle` and it's not recommended to edit it manually

Is it desirable to implement something similar for deno_emit? If not, why? If so, should that be configurable?

dsherret commented 1 year ago

I think that can be added by people if they want it in the output. That said, probably it creates some complications with source maps so maybe it should be handled by this crate? Or maybe it can be configurable?