Rule suggestion: no-compare-to-new - Githubissues

denoland / deno_lint

Blazing fast linter for JavaScript and TypeScript written in Rust

https://lint.deno.land/

MIT License

1.53k stars 172 forks source link

Rule suggestion: no-compare-to-new #1185

Open rotu opened 1 year ago

rotu commented 1 year ago

Using ===, ==, or switch with an object or array literal is always false.

The below are all examples of erroneous comparisons that could be flagged:

x === {}
switch (x) { case {}: /* ... */ }
Object.is(x, {}) (assuming Object.is has not been deleted or tampered with)

Additionally, if the type of x is known, the following could be flagged:

x == {} if x is not an object
x.includes({}), x.indexOf({}), x.lastIndexOf({}) if x is an Array
x.has({}), x.get({}), x.delete({}) if x is a Map or WeakMap
x.has({}), x.delete({}) if x is a Set or WeakSet

Similar to this suggested eslint rule: https://github.com/eslint/eslint/issues/15222

bartlomieju commented 4 months ago

Seems reasonable 👍 contributions are welcome