Closed dsherret closed 3 months ago
Just looked into this and it seems to be explicitly not allowed here: https://github.com/denoland/deno_lint/blob/main/src/rules/no_fallthrough.rs#L271
Eslint seems to only allow it when setting allowEmptyCase
(https://eslint.org/docs/latest/rules/no-fallthrough#allowemptycase).
I would argue that the empty case is a formatting concern (the formatter will collapse it) and adding a comment here is mostly used to document a case. With the rule as-is there's no way to document why a specific case exists in a list of cases without adding a deno-lint-ignore comment at the top, so I think we should just allow this because I'm not sure what problem it's trying to prevent.
We should allow it.
May I work on this issue?
I often do stuff like this:
There is no fallthrough here, but deno lint warns about it because of the comment on line 3