Closed chengr4 closed 8 months ago
Looks like a good start. Please run tools/format.ts
to format the code and make CI happy.
hi @bartlomieju,
I fixed CI and added test cases for test_parse_global_ignore_directives
. Please check it out when you get time, and tell me anything I missed 🙏.
BTW, There are two things I have zero confidence.
comment_text_without_reason
and IGNORE_COMMENT_REASON_RE
<= I hope these are ok.let comment_text =
IGNORE_COMMENT_CODE_RE.replace_all(&comment_text_without_reason, ",");
About adding &
in front of comment_text_without_reason
, I only followed the instruction of the compiler and hope it was the best practice.
hi @bartlomieju, I fixed CI and added test cases for
test_parse_global_ignore_directives
. Please check it out when you get time, and tell me anything I missed 🙏.BTW, There are two things I have zero confidence.
- Variable Naming: eg.
comment_text_without_reason
andIGNORE_COMMENT_REASON_RE
<= I hope these are ok.let comment_text = IGNORE_COMMENT_CODE_RE.replace_all(&comment_text_without_reason, ",");
About adding
&
in front ofcomment_text_without_reason
, I only followed the instruction of the compiler and hope it was the best practice.
Yeah, these seems fine 👍
Sorry, I pressed the button accidentally. I didn't intend to rush you 😓.
Hi,
This is my first contribute in deno codebase. I feel nervous and hope it can go well.
This PR is for #1076.
Please check my updates and slowly guide me to the right direction 🙏. Thanks in advance
TODO
test_parse_global_ignore_directives
(done at 2024.01.20)