search

denoland / deno_std

The Deno Standard Library
https://jsr.io/@std
MIT License
2.83k stars 581 forks source link

BREAKING(assert): remove `assert` from module names #5176

Closed iuioiua closed 17 hours ago

iuioiua commented 5 days ago

Closes #5162

kt3k commented 4 days ago

I think this change can't be done in a single PR. I think the relative import of ./assert/* from the outside would break deno publish --dry-run

iuioiua commented 4 days ago

This is not yet complete. I should be doable in a single PR.

kt3k commented 4 days ago

If the commit tag of this PR is BREAKING(assert), then only assert package is upgraded by this. But all depending packages need to have refactor(package) commit to follow assert change. We need those 2 different kinds of upgrades, but they can't be expressed in a single PR

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.30%. Comparing base (cadf85c) to head (ca2943d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5176 +/- ## ======================================= Coverage 95.30% 95.30% ======================================= Files 460 460 Lines 38056 38056 Branches 5577 5577 ======================================= Hits 36269 36269 Misses 1745 1745 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iuioiua commented 2 days ago

@std/assert imports in other packages will be updated to their most-specific module specifiers in a follow-up PR.