Closed iuioiua closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.76%. Comparing base (
fc2975b
) to head (7cc1684
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm in favor of this change. The option name json
doesn't describe what it changes.
I slightly feel allowDuplicatedKeys
is a bit more natural. What do you think?
I slightly feel
allowDuplicatedKeys
is a bit more natural. What do you think?
I don't think it's any more natural than what it is now.
I did a quick search - "duplicate keys" seems more correct.
What's changed
ParseOptions.json
has been renamedParseOptions.allowDuplicateKeys
. This change only affects those that previously setParseOptions.json
totrue
. No changes in behavior have been made.Motivation
This name more clearly describes how the option affects the behavior of
parse()
.Migration guide
To migrate, use the
allowDuplicateKeys
option instead of thejson
option forparse()
.Related
Towards #5195