Closed timreichen closed 3 days ago
Attention: Patch coverage is 95.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 95.81%. Comparing base (
ee46006
) to head (541a8b5
).
Files | Patch % | Lines |
---|---|---|
csv/_io.ts | 93.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
renames fullLine to line and line to currentLine renames parseField to currentLineLoop
I don't see the point of these renames. Can you revert these changes?
renames fullLine to line and line to currentLine renames parseField to currentLineLoop
I don't see the point of these renames. Can you revert these changes?
I think it is weird to have an assignment which then is stored in another variable because the former is mutated. How about
let fullLine = this.#readLine();
...
let line = fullLine;
opt
tooptions
argumentfullLine
toline
andline
tocurrentLine
~parseField
tocurrentLineLoop
~