denoland / deno_std

The Deno Standard Library
https://jsr.io/@std
MIT License
2.83k stars 582 forks source link

test(csv): add grapheme length test #5304

Closed timreichen closed 3 days ago

timreichen commented 3 days ago
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (9d5d887) to head (c2cb662).

Files Patch % Lines
csv/_io.ts 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5304 +/- ## ======================================= Coverage 95.81% 95.81% ======================================= Files 457 458 +1 Lines 37879 37890 +11 Branches 5567 5567 ======================================= + Hits 36293 36304 +11 Misses 1546 1546 Partials 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timreichen commented 3 days ago

@kt3k on second thought: Is this something we might want in @std/text? grapheme-splitter has over 6mil weekly downloads.

kt3k commented 3 days ago

Maybe a good possible candidate