denoland / denokv

A self-hosted backend for Deno KV
https://deno.com/kv
MIT License
475 stars 23 forks source link

Update docs: unexpected argument '--sqlite-path' found when following examples #28

Closed john-pope closed 11 months ago

john-pope commented 11 months ago

When following documentation, I am trying to use the denokv standalone and am getting

error: unexpected argument '--sqlite-path' found

Usage: denokv --sqlite-path <SQLITE_PATH> serve [OPTIONS] --access-token <ACCESS_TOKEN>

For more information, try '--help'.

This is when running with either installing with cargo or the docker container, reproduce with:

export DENO_KV_ACCESS_TOKEN=$(openssl rand -base64 15)
docker run -it --init -p 4512:4512 -v ./data:/data ghcr.io/denoland/denokv serve --sqlite-path /data/denokv.sqlite serve --access-token $DENO_KV_ACCESS_TOKEN

--sqlite-path has to be before serve, docs need to be updated

john-pope commented 11 months ago

Needs to be fixed in the readme:

https://github.com/denoland/denokv/blob/main/README.md?plain=1#L20 https://github.com/denoland/denokv/blob/main/README.md?plain=1#L77

And the blog post:

https://deno.com/blog/kv-is-open-source-with-continuous-backup (first example)