search

denoland / deploy_feedback

For reporting issues with Deno Deploy
https://deno.com/deploy
74 stars 5 forks source link

code: DEPLOYMENT_FAILED is automatically getting promoted to production #269

Closed cj closed 7 months ago

cj commented 2 years ago

Hi,

Even though Deno Deploy recognizes it as a failed deployment:

image

It is still getting promoted automatically to production, which brings down the production site.

Expected Result:

If Deno Deploy returns code: DEPLOYMENT_FAILED it should mark the deployment as failed and not promote it to production.

arnauorriols commented 7 months ago

FTR, DEPLOYMENT_FAILED does not mean the creation of the deployment failed, but rather that this deployment has failed at runtime during request handling.