search

denoland / deploy_feedback

For reporting issues with Deno Deploy
https://deno.com/deploy
74 stars 5 forks source link

[KV Feedback]: Access default database outside of master branch #550

Open Joehoel opened 10 months ago

Joehoel commented 10 months ago

🔍

Type of feedback

Feature request

Description

I have a production deployment that does not use Deno KV yet. But my development branch does. I can't create a preview deployment for my development branch because the default database is only available on the master branch.

Is it possible to make it available on other branches?

Steps to reproduce (if applicable)

  1. Create a Deno API.
  2. Deploy to Deno Deploy.
  3. Create a new branch with a KV implementation.
  4. Make preview deployment.

Expected behavior (if applicable)

Preview deployment is successful and creates a KV instance.

Possible solution (if applicable)

No response

Additional context

No response

cknight commented 10 months ago

Not sure I'm following this, specifically what you mean when you say "because the default database is only available on the master branch". If you deploy your development branch which changes to access KV, your KV writes/reads will happen on a KV-Preview database. This database is created for use by all non-master branches/preview builds. When you promote your code to master, it will use a separate dedicated production database.