Closed magurotuna closed 1 month ago
You can just @ts-ignore
these APIs, they are still there but they are "soft-deprecated".
Thanks for the info, that should be a good fix for the moment, but we will need to move away from these deprecated APIs eventually, so I'm going to try to explore if the migration of deployctl to Deno 2.0 is easy
Sounds good - I bet these stream
are Deno.stdout
or Deno.stderr
which now have isTerminal()
method that does the same thing.
It's actually a bit more complicated than it looks, because the use of the deprecated API is inside the dependency of dependency, which effectively is beyond our control - I think it's the best timing now to upgrade our dependencies as a whole. At first glance we can utilize stable version of std to achieve the same functionality. I'm checking it right now.
We get type errors when we run deployctl with Deno 2.0 RC version:
https://github.com/denoland/deployctl/actions/runs/10715041741/job/29709772144?pr=313#step:8:205