Improve manual routing - Githubissues

denoland / dotland

[Archived] deno.land website

https://deno.land

MIT License

957 stars 626 forks source link

Improve manual routing #2177

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

Redirect /manual to /manual/introduction, fix #2164
Strip .md from manual content to avoid extra redirect requests. This is safe since I checked the manual and didn't find any .md that isn't a internal link.

kidonng commented 2 years ago

Also, I want to propose the idea to always version the manual URL as well (i.e. https://deno.land/manual always redirect to a specific version https://deno.land/manual@va.b.c). The same manual link may show different content as new versions are released, which is not consistent with how the module pages works.

lukemcdo commented 2 years ago

Without the redirection, the https://deno.land/manual page has numerous broken links. Is this open because the issue is in progress, or should I open a new issue?

kidonng commented 2 years ago

Hmm, CI encountered 500 on GitHub raw... I think we really should stop importing stuff from GitHub raw and use a CDN (like jsDelivr) instead.

crowlKats commented 2 years ago

@kidonng can you rebase? also, could you add a condition that if no version is specified, redirect to latest version?

crowlKats commented 2 years ago

going to /manual redirects to /manual@v1.24.3/introduction, but going to /manual@v1.24.3 doesnt