search

denoland / dotland

[Archived] deno.land website
https://deno.land
MIT License
957 stars 626 forks source link

Fix markdown table overflow #2307

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

https://github.com/denoland/dotland/pull/2304#issuecomment-1195477952

kidonng commented 2 years ago

There are some markdown-related styles here:

https://github.com/denoland/dotland/blob/f583ec6b6d86b36e49f16a229223ee7ce3f7223f/static/app.css#L145-L155

Would you like to see them moved into gfm.css.ts?

crowlKats commented 2 years ago

the thing is, this wasnt necessary in the previous design, and nothing with the rendering has changed, so there is def a solution without modifying app.css

crowlKats commented 2 years ago

Closing in favour of #2310

kidonng commented 2 years ago

the thing is, this wasnt necessary in the previous design, and nothing with the rendering has changed, so there is def a solution without modifying app.css

But from what I can tell the culprit is the table, so there's nothing wrong fixing them directly.

I may be misleading, this pull request doesn't change app.css (it's gfm.css.ts), I just saw there are some (duplicate?) styles that may be worth cleaning up and brought it up.

crowlKats commented 2 years ago

regardless if it's app.css or gfm.css.ts, it wasnt necessary before. i will merge this PR as-is and look into it on a later date for a proper fix