search

denoland / dotland

[Archived] deno.land website
https://deno.land
MIT License
957 stars 626 forks source link

Make it clearer which tab is selected in search modal #2354

Closed lucacasonato closed 1 year ago

lucacasonato commented 2 years ago

Currently the selected item is just highlighed very subtly using a slightly different text color. There should be a clearer distinction, for example by having an underline on the selected tab.

crowlKats commented 2 years ago

There is an underline though.

lucacasonato commented 2 years ago

There is no underline: image

crowlKats commented 2 years ago

interesting:

Screenshot 2022-08-08 at 14 32 15
crowlKats commented 2 years ago

this seems to happen on chrome & safari (in ff it doesnt):

Screenshot 2022-08-08 at 14 43 24
danyalasif commented 2 years ago

I have tested this a bit and it always gives the INJECT_CSS_ERROR on chrome, I was able to fix this by using border directly to give the underline and remove the css call.

Is this issue open for PR?