fix: use https for getVersionList

denoland / dotland

[Archived] deno.land website

https://deno.land

MIT License

957 stars 626 forks source link

fix: use https for getVersionList #2372

Closed crowlKats closed 2 years ago

ry commented 2 years ago

Can you provide some more information? What is this fixing?

crowlKats commented 2 years ago

because it currently uses http and not https, publishing modules currently doesnt work as the clientside errors with mixed content.

lucacasonato commented 2 years ago

Oh missed the above comment.

lucacasonato commented 2 years ago

Can't you proxy the browser requests through the dotland backend, rather than talking to s3 directly?

crowlKats commented 2 years ago

you mean adding a route to act as a proxy? it could be done, but i think its fine like this, no? also, i want to remove the need of this complciated setup we have with getVersionInfo for registering a module, but havent investigated it yet in-depth.

kt3k commented 2 years ago

Can you provide some more information? What is this fixing?

This fixes the first text input box in https://deno.land/add_module, which currently always shows error for any module name. I think this prevents new authors publishing a new module