Issue with raw file links on deno.land/x

denoland / dotland

[Archived] deno.land website

https://deno.land

MIT License

957 stars 626 forks source link

Issue with raw file links on deno.land/x #2385

Closed GJZwiers closed 2 years ago

GJZwiers commented 2 years ago

Trying to download a raw code file from the registry is prevented in the browser (Firefox) due to an unencrypted connection.

Steps to reproduce:

Go to a module on /x.
Click on 'Raw'

It does not seem to happen for all files. For example this lodash file can be downloded as raw without issue.

Firefox version: 104.0b9

kitsonk commented 2 years ago

@crowlKats could this be because of the change to how we access the raw files?

crowlKats commented 2 years ago

@kitsonk yea, this is because we dont use the CDN anymore, and instead directly the s3 bucet which only is accessible via http

kitsonk commented 2 years ago

Well, that is going to be a problem, as browsers with a https connection won't allow the downgrade. Makes the links useless.

I hadn't appreciated it was just a redirect, I had assumed we would consume off S3 in Deploy for what we need but still provide a secure connection for serving of raw files.

crowlKats commented 2 years ago

it seems to me that we need to keep the CDN around sadly...

kitsonk commented 2 years ago

Yes.