search

denoland / dotland

[Archived] deno.land website
https://deno.land
MIT License
957 stars 626 forks source link

CodeBlock shows scrollbars #2492

Closed jespertheend closed 2 years ago

jespertheend commented 2 years ago

image This is both on Windows and Ubuntu, macOS is fine if you have scrollbars set to disappear in the OS settings.

lucacasonato commented 2 years ago

This is probably using overflow: scroll rather than overflow-y: auto.

jespertheend commented 2 years ago

Oops, I forgot to mention, I dug a little deeper into this. overflow: scroll is applied here: https://github.com/denoland/doc_components/blob/edc545e8d00b5fd2387aeeb029b2157c5bf10c63/doc/usage.tsx#L74 I was about to submit a PR but then I realised this might break some things and I gave up on it. 😶 I'm not sure in what other places the Usage component is used.

crowlKats commented 2 years ago

@jespertheend it's only used in 2 places, its fine that change that, so PR is welcome

jespertheend commented 2 years ago

I've opened https://github.com/denoland/doc_components/pull/35 and I've verified that it indeed fixes the issue. Once that is merged the importmap will still need to be updated to point to the new commit.