search

denoland / dotland

[Archived] deno.land website
https://deno.land
MIT License
957 stars 626 forks source link

fix: properly handle resolveSourceHref search params #2675

Closed xnuk closed 1 year ago

xnuk commented 1 year ago

The bug I had:

  1. Visit https://deno.land/x/deno@v1.30.0/cli?doc
  2. Click the icon seems like 'view source'
  3. It's exactly same page but different url: https://deno.land/x/deno@v1.30.0/cli?doc?source
  4. https://deno.land/x/deno@v1.30.0/cli?doc?source?source
  5. https://deno.land/x/deno@v1.30.0/cli?doc?source?source?source
  6. https://deno.land/x/deno@v1.30.0/cli?doc?source?source?source?source

I'm not sure this fixes the bug, btw.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

kt3k commented 1 year ago

Does this only happen with x/deno?

xnuk commented 1 year ago

Any directories that does not have mod.{js,ts} can reproduce the problem, for example x/oak:

crowlKats commented 1 year ago

Thanks for the PR. We don't use this repository anymore, as the website went closed-source, however I have backported your PR in our repository.