search

denoland / dotland

[Archived] deno.land website
https://deno.land
MIT License
956 stars 626 forks source link

Use marked-smartypants to replace punctuation in markdown content with smart punctuation #2755

Closed rojvv closed 1 year ago

rojvv commented 1 year ago

Waiting on https://github.com/denoland/deno-gfm/pull/66.

Closes https://github.com/denoland/manual/issues/643.

kt3k commented 1 year ago

What problem does this solve?

rojvv commented 1 year ago

@kt3k https://github.com/denoland/manual/issues/643

kt3k commented 1 year ago

That seems fixed with https://github.com/denoland/manual/pull/644

rojvv commented 1 year ago

Yes, we made the quotes consistent in the manual so we can proceed with this. I’ve also explained everything to @lambtron:

We should be using normal punctuation (e.g. ""'') in the markdown source, but convert them to automatically smart punctuation (e.g. “”‘’). This PR does that.

rojvv commented 1 year ago

If you run a preview of this locally and compare it with https://deno.land, you’ll see that all the punctuation are now smart punctuation.

Note that this does not apply for code blocks.