search

denoland / fastwebsockets

A fast RFC6455 WebSocket implementation
https://docs.rs/fastwebsockets/
Apache License 2.0
880 stars 66 forks source link

add handshake::connect function #61

Closed 86maid closed 9 months ago

86maid commented 11 months ago

I added a connect function to make it easy to connect.

86maid commented 11 months ago

oh no

xchuang233 @.***

---Original--- From: "Divy @.> Date: Mon, Dec 18, 2023 14:42 PM To: @.>; Cc: @.>;"State @.>; Subject: Re: [denoland/fastwebsockets] add handshake::connect function (PR#61)

@littledivy commented on this pull request.

Thanks for the PR but I've decided not to add a connect function because of the customizations we need to support. fastwebsocket::handshake is intended to be a low-level API to build a connector on top of.

Moreover, I do not want to add tokio-rustls and webpki-roots as dependencies.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

littledivy commented 9 months ago

Closing due to the reasons stated above.