search

denoland / fresh

The next-gen web framework.
https://fresh.deno.dev
MIT License
12.24k stars 626 forks source link

docs: double `the` word on `Plugins` section #2518

Closed Iuriiiii closed 3 months ago

Iuriiiii commented 3 months ago

Hi, A little grammar error there:

image

It can be fixed easily just removing the duplicated the word in the file docs/latest/concepts/plugin.md:83:29

Iuriiiii commented 3 months ago

Just in case, i tried to open a pr, but i couldn't due a git error (permission denied)

marvinhagemeister commented 3 months ago

@Iuriiiii The way Pull Requests work in GitHub or elsewhere is that you fork the repository, push your changes to a branch in your fork and the create a pull request from your fork that targets the original repository. The permission error you're seeing means that you tried to push the branch into this repository instead of your fork. Create a fork first.

Iuriiiii commented 3 months ago

@Iuriiiii The way Pull Requests work in GitHub or elsewhere is that you fork the repository, push your changes to a branch in your fork and the create a pull request from your fork that targets the original repository. The permission error you're seeing means that you tried to push the branch into this repository instead of your fork. Create a fork first.

JAJAJAJAJA You're right!! So sorry, incredible that you have to explain me something so basic, long time ago since I done a PR to a open source project, my bad 😬