denoland / fresh

The next-gen web framework.
https://fresh.deno.dev
MIT License
12.05k stars 607 forks source link

Incorrect processing of URLSearchParams when submitting forms inside f-nav-client #2567

Closed limkaa4 closed 2 days ago

limkaa4 commented 2 days ago

If we have some example form

 <form>
        <label>
            <input type="checkbox" name="interests" value="sports">
            Sports
        </label><br>
        <label>
            <input type="checkbox" name="interests" value="music">
            Music
        </label><br>
        <label>
            <input type="checkbox" name="interests" value="travel">
            Travel
        </label><br>
        <input type="submit" value="Submit">
    </form>

Now, if we pick all interests and submit form. On search params we looks like this

?interests=travel

but correct is

?interests=sports&interests=music&interests=travel

It seems that replacing set with append is enough to fix it on this

marvinhagemeister commented 2 days ago

Thanks for the excellent bug report! You're spot on that it should've been .append() there 👍