search

denoland / manual

Deprecated - find these resources on docs.deno.com instead
https://github.com/denoland/deno-docs
MIT License
161 stars 237 forks source link

Auto format PR's changes #371

Closed kt3k closed 2 years ago

kt3k commented 2 years ago

We should create github action workflow which automatically formats the files in PR's branch and push it to that branch if there's any unformatted files

bartlomieju commented 2 years ago

When we set up this repo @lucacasonato and I tried to add auto-format but there was a GH Actions limitation that didn't allow to push to contributors branch. I'm not sure if that's still the case

ayame113 commented 2 years ago

If there is a limit on push from GitHub Actions, how about using reviewdog to suggest a format change?

For example, https://github.com/ayame113/js-playground/pull/4#discussion_r932054275 and https://github.com/ayame113/js-playground/blob/5be8bfc0fba70c849cbfcacaf2c97764d76d15c0/.github/workflows/suggest_change.yml

kt3k commented 2 years ago

If there is a limit on push from GitHub Actions, how about using reviewdog to suggest a format change?

Sounds like a good workaround to me