search

denoland / node_shims

npm packages providing shims for the Deno namespace and other globals. Useful for running Deno-first programs on Node.
MIT License
149 stars 29 forks source link

Only supports intel? #152

Closed mxcl closed 9 months ago

mxcl commented 1 year ago

we're having some issues with dnt published node modules on aarc64 (mac and linux) and we’re wondering if this maybe is something to do with it?

https://github.com/denoland/node_shims/blob/e8c49ce981b782e88e18cd46b60e129040cb1994/packages/shim-deno/src/deno/stable/variables/build.ts#L6

Thanks for your time.

mxcl commented 1 year ago

Yeah so I wrote a test to prove deno-shims always assumes intel: https://github.com/teaxyz/lib/actions/runs/5104970279/jobs/9176249682?pr=11

We can probs work around it by delegating to process.arch instead, still up for a discussion about this. Thanks.

trgwii commented 1 year ago

This is probably a remnant of some old code that just has it hardcoded and is missing a TODO, I don't think a PR that adds proper support would be a bad idea, as long as it conforms with the Deno types.