Open secext2022 opened 1 month ago
It might be related to the vtable layout for one-byte consts.
I shall say: Ouch. Mea culpa.
I think we may just need to special case vtable layout for Android as well -- the question would be what that layout is. Perhaps the relative vtable ABI?
Yeah; it might be as easy as applying the Windows vtable layout (only one destructor) for Android but of course the issue is testing the change.
I'm thinking of a way to, at test time, verify the vtable layout so as to ensure any issues on different platforms become build time issues instead of runtime ones.
There is test, but just skip for Android:
// one-byte "const" test
#[cfg(not(target_os = "android"))]
Reproduce code (
rusty_v8 v0.91.1
):compile and run on Android phone (
adb shell
):crash log from
adb logcat
:deno_core
crash on Android aarch64, so I write this code for the BUG.https://github.com/denoland/deno_core/issues/738