search

denoland / rusty_v8

Rust bindings for the V8 JavaScript engine
https://crates.io/crates/v8
MIT License
3.08k stars 300 forks source link

Use of deprecated APIs in binding.cc #1478

Closed mmastrac closed 1 week ago

mmastrac commented 1 month ago

When moving to 12.6, we bumped into a large number of deprecated APIs.

To work around it, the entire binding file is now ignoring deprecated APIs, but these will need to be bumped to the replacement APIs.

  ../../../../src/binding.cc:1225:24: error: 'SetAccessor' is deprecated: Use SetNativeDataProperty instead [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:1239:35: error: 'NamedPropertyHandlerConfiguration' is deprecated: Provide interceptor callbacks with new signatures instead (NamedPropertyXxxCallback) [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:1253:35: error: 'IndexedPropertyHandlerConfiguration' is deprecated: Provide interceptor callbacks with new signatures instead (IndexedPropertyXxxCallbackV2) [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:3739:11: error: 'WrapperDescriptor' is deprecated: WrapperDescriptor is deprecated, see crbug.com/338411141. [-Werror,-Wdeprecated-declarations]
  ../../../../v8/include/v8-cppgc.h:90:3: note: 'CppHeapCreateParams' has been explicitly marked deprecated here