denoland / rusty_v8

Rust bindings for the V8 JavaScript engine
https://crates.io/crates/v8
MIT License
3.08k stars 299 forks source link

Applying modified patches from FreeBSD ports (www/deno/files) #1483

Open Munrok opened 1 month ago

Munrok commented 1 month ago

Patches from FreeBSD port tree been modified to fit current state of repository and were applied. Source of original patch files https://github.com/freebsd/freebsd-ports/tree/main/www/deno/files Subset of patches used: patch-cargo-cratesv8*

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

Munrok commented 1 month ago

I see that some checks were aborted after dozen of seconds. Does it mean additional work should be done in order to prepare version that can go further in checking process?

bartlomieju commented 1 month ago

@Munrok the whole build process requires various directories to be pulled from repos like https://github.com/denoland/chromium_build.git or https://github.com/denoland/v8.git. If you'd like to upstream your changes you'll need to open PR against these repos. That said, I'm not super happy to float several patches in V8 or abseil. Have you tried opening CL against upstream repos?