search

denoland / saaskit

A modern SaaS template built on Fresh.
https://deno.com/saaskit
MIT License
1.17k stars 142 forks source link

proposal: show number of comments of an item on the main page next to the timestamp #209

Closed brunocorrea23 closed 1 year ago

brunocorrea23 commented 1 year ago

Similar to what Hacker News does (https://news.ycombinator.com/) Screenshot 2023-05-18 at 15 56 20

iuioiua commented 1 year ago

We previously had comment counts but removed them in #171 because it wasn't worth the added complexity and overhead. However, if Deno.Kv.count() is implemented, it'll be worth considering adding this feature back in.

lino-levan commented 1 year ago

@iuioiua would you be willing to bring this back via an index? Something like a cached comment count on the post object itself?

iuioiua commented 1 year ago

Slightly likely not. However, I'd be happy to consider a PR that does this without incurring too much of a complexity cost.

iuioiua commented 1 year ago

It seems this feature would incur a similar complexity cost that voting functionality has incurred on item logic, which has been a bit of a pain point for the codebase, IMO. For that reason, I'd rather not have this feature. WDYT, @brunocorrea23?

iuioiua commented 1 year ago

Gently pinging @brunocorrea23.