search

denoland / saaskit

A modern SaaS template built on Fresh.
https://deno.com/saaskit
MIT License
1.21k stars 148 forks source link

fix: avoid showing "No items found" stats in `<ItemsList />` #559

Closed roberto-morado closed 1 year ago

roberto-morado commented 1 year ago

fixes #472

@iuioiua this is as simple as I got, without being too intrusive; I personally like it; the problem was a bug regarding the state change of the variable isLoadingSig, I was able to avoid it by initializing the variable as undefined and bypassing it with the conditional rendering not sure if is worth taking another look at it some other time.

Note: The simplicity of this PR does not reflect at all the time that took me to get there — just for the record.

roberto-morado commented 1 year ago

@iuioiua man! how right you were. This reads way better.

roberto-morado commented 1 year ago

After seeing this PR I cannot help but wonder what was I doing this whole time? 🤔