search

denoland / saaskit

A modern SaaS template built on Fresh.
https://deno.com/saaskit
MIT License
1.15k stars 140 forks source link

feature: add Google Analytics plugin #580

Closed revgum closed 8 months ago

revgum commented 1 year ago

Before writing the README updates, I wanted to get this PR out for 👁️ and 🧠 @iuioiua .. I lifted this from the Fresh site and translated it into a plugin here. I've tested it locally, and it's working great with localhost.

This might serve as a good starting point for #72

Screenshot 2023-09-12 at 5 46 56 AM Screenshot 2023-09-12 at 5 47 05 AM
iuioiua commented 1 year ago

This looks cool! Let's look at merging this after v1. In the meantime, we can improve on test coverage and whatever else 👍🏾

iuioiua commented 10 months ago

Hi @revgum, we're pushing the launch of v1 out till early next year now. And we'd be happy to accept more features before then. Is this PR something you still like to pursue for before v1 is launched? If so, please let me know once ready for review.

deer commented 9 months ago

@iuioiua, as an alternative, there's something I created: https://deno.land/x/fresh_ga4@0.0.3 Although you probably want me to add some test coverage to my repo as well!

If you want I could create a PR that integrates the existing plugin into saaskit.

iuioiua commented 9 months ago

Hi @deer, that looks great! I'd gladly look at a PR that makes use of that plugin. I think this PR has gone stale. And yes, it would be great if there were some tests added, but it might do for now 🙂

ooker777 commented 8 months ago

UA has officially stopped working. It's time to take this article down or at least have an update to point to working plugins https://deno.com/blog/ga-with-deno-deploy

iuioiua commented 8 months ago

UA has officially stopped working. It's time to take this article down or at least have an update to point to working plugins https://deno.com/blog/ga-with-deno-deploy

That article is unrelated to this PR (which uses GA4) and this repo.

iuioiua commented 8 months ago

Closing in favour of #654. Either way, thank you, @revgum.

ooker777 commented 8 months ago

oh I didn't know that Deno Saaskit, Deno Blog and Deno Deploy are separate projects. By saying "point to working plugins" I was thinking about the 2 plugins in here. I don't know which repo I should raise the issue, so I do it in Discord

iuioiua commented 8 months ago

Ah, I see you created https://github.com/denoland/deno-docs/issues/277. Yep, that's the right way to fix it. Thanks!