search

denoland / saaskit

A modern SaaS template built on Fresh.
https://deno.com/saaskit
MIT License
1.21k stars 148 forks source link

feat: harden headers security #592

Closed Jabolol closed 1 year ago

Jabolol commented 1 year ago

Work in progress. See #591 for the relevant discussion.

Jabolol commented 1 year ago

Good start! See if this is valuable to you in this PR.

Oh I completely missed that section of the docs! It’s most useful, thanks for the heads up. I’ll implement the changes requested ASAP.

Jabolol commented 1 year ago

Once https://github.com/denoland/fresh/pull/1787 lands we will be able to achieve an A+ score

iuioiua commented 1 year ago

Once denoland/fresh#1787 lands we will be able to achieve an A+ score

Let's add a @todo in this PR. I'd like to merge this PR sooner rather than depend on that PR.

Jabolol commented 1 year ago

Looking better! Can you please add a test?

Done! Comment improved and added a test case. Let me know if I should add something else

iuioiua commented 1 year ago

Test logic looks good! However, are we able to do this in a /plugins/security_headers_test.ts file?

Jabolol commented 1 year ago

Test logic looks good! However, are we able to do this in a /plugins/security_headers_test.ts file?

Yeah, that's better indeed. Moved it.

iuioiua commented 1 year ago

Is this ready for review?