chore: upgrade to Fresh 1.6.1 and std 0.208.0

denoland / saaskit

A modern SaaS template built on Fresh.

https://deno.com/saaskit

MIT License

1.22k stars 151 forks source link

chore: upgrade to Fresh 1.6.1 and std 0.208.0 #646

Closed deer closed 11 months ago

deer commented 11 months ago

closes https://github.com/denoland/saaskit/issues/644

I see the guidelines have changed since I last contributed (thanks github!) and that caused me to look for an issue. Fortunately there was the above, but I see you want tailwind as well. I'll open this as a draft for now.

deer commented 11 months ago

@iuioiua, this is ready to go now. Although you might consider some style tests somewhere. I almost botched this by forgetting to add the styles.css file. Of course the site was unstyled, but all the tests were passing.

iuioiua commented 11 months ago

Pretty much LGTM! I'll give this a spin tomorrow before approving.

As for the styles test, let's create an issue to fix after we land this PR.

deer commented 11 months ago

Thanks guys. I'll try again on Friday, first ensuring a near pixel perfect match. I guess I need to familiarize myself with the app's functionality 😅

deer commented 11 months ago

Some progress here, but it's a slog. I had to hack it by leveraging the safelist in the config, so obviously something is majorly wrong. Additionally I haven't managed to fix the inputs on the submit page. (They're appearing as some sort of medium gray when not logged in, but I think they should be the same as the background color.)

On the positive side, I'm obviously deep in the code checking out all the pages. So maybe I'll finally have something else to say in this repo after (if!?) I fix this 🙃

If either of you have any great ideas, I'm ready to be saved. Otherwise I'll continue later.

iuioiua commented 11 months ago

Hm... I think Tailwind can't recognise classes if stored in variables. The fix may be as simple as removing these "class variables", like LINK_STYLES, and just using the classes directly. We can also create custom classes and reuse those.

deer commented 11 months ago

Still fighting with active links, but it's overall much better now.

deer commented 11 months ago

As per https://tailwindcss.com/docs/border-width, tailwind does not do border-1, so I had to define this in tailwind.config.ts.
The solution to the link issue was to change the position of the exclamation mark.
Somehow tw-ring-opacity: 0.5; was getting inserted into the old version automatically; I had to manually apply it here with ring-opacity-50.