search

denoland / std

The Deno Standard Library
https://jsr.io/@std
MIT License
3.15k stars 618 forks source link

feat(http/unstable): `parallel-file-server` module #5786

Closed iuioiua closed 2 months ago

iuioiua commented 2 months ago

Closes #5681

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (a81742a) to head (c56fa0b). Report is 23 commits behind head on main.

Files Patch % Lines
http/_get_server_args.ts 6.66% 28 Missing :warning:
http/file_server.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5786 +/- ## ========================================== - Coverage 96.26% 96.24% -0.02% ========================================== Files 481 482 +1 Lines 38738 38743 +5 Branches 5615 5615 ========================================== - Hits 37291 37290 -1 - Misses 1406 1412 +6 Partials 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kt3k commented 2 months ago

Should we add some warning about that the script is still unstable?

iuioiua commented 2 months ago

There are multiple ways we can go about having a HTTP file server work in parallel. I'm not sure this approach is best as I'm not sure having a whole new endpoint is the best way to go. Alternatively, we could have --parallel just work with Deno.serve(), which would make this work a lot simpler.