search

denoland / std

The Deno Standard Library
https://jsr.io/@std
MIT License
3.17k stars 621 forks source link

make @std/path cross-runtime #6164

Open iyefrat opened 5 days ago

iyefrat commented 5 days ago

Is your feature request related to a problem? Please describe.

I'm looking for a good isomorphic path library in javascript that can be used in both the browser and Node. I can't move to Deno just yet, but @std/path looks great!

From https://github.com/denoland/std/issues/4914 it seems like it may already be cross-platform, or at least close to it. However it's not marked as such on jsr.

Describe the solution you'd like

If it's indeed cross platform, update the jsr page. If not, what are the gotchas? can a subset of it be safely used? Is there a way I can check myself other than trying to use it and hoping I bump into incompatibility errors before they cause actual bugs?

BlackAsLight commented 5 days ago

After a quick skim of the source code, I don't see why it wouldn't work on nodejs. The library just doesn't seem to be tested for nodejs

iyefrat commented 5 days ago

From looking a bit deeper, this is the only deno only section i found: https://github.com/denoland/std/blob/df6f32c6bcccc4b46c38be415cecaf1f7742ec10/path/posix/resolve.ts#L2

Also in packages that are marked as node compatible (e.g. @std/yaml), I couldn't find anything in the code that checked that, i guess the org just enables it on jsr once the package doesn't visibly depend on any Deno specific things?