Closed timreichen closed 1 day ago
Attention: Patch coverage is 92.15686%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
93e0cd6
) to head (ef0a93d
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
cli/unstable_prompt_select.ts | 92.15% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
unstable_prompt_select.ts
as we want to accept every new feature as unstable feature? ref: https://github.com/denoland/std/blob/main/.github/CONTRIBUTING.md#new-features-in-stable-packages-version--100Deno.stdin
and Deno.stdout
? Mocking utilities are available from @std/testing/mock
- Can you rename the file to
unstable_prompt_select.ts
as we want to accept every new feature as unstable feature? ref: https://github.com/denoland/std/blob/main/.github/CONTRIBUTING.md#new-features-in-stable-packages-version--100- Can you try to write test cases by spying/stubing methods of
Deno.stdin
andDeno.stdout
? Mocking utilities are available from@std/testing/mock
I've added some tests but need help resolving the current errors. The tests ran successfully locally. I don't know, why they occur and how to fix them.
The tests ran successfully locally. I don't know, why they occur and how to fix them.
I think you also need to stub Deno.stdin.setRaw
(with empty function) to avoid error. (The error in CI seems happening because the stdin is not terminal in CI)
Im really excited for this one! Its exactly what I've been looking for! <3
Ref: https://github.com/denoland/std/issues/4678
Changes Adds
promptSelect()
cli function.