search

denolehov / obsidian-git

Backup your Obsidian.md vault with git
MIT License
6.15k stars 252 forks source link

[Bug]: Doesn't commits and pushes automatically #575

Closed alexcmx closed 10 months ago

alexcmx commented 11 months ago

Describe the bug

Appears notification that there are no changes in repo, but actually I can make git commit and push and there is a lot of changes. Looks like plagin woks a bit strange or maybe I understand it not so well May be it can't make commit?

изображение_2023-08-05_162030400 image image image image

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

No response

Steps to reproduce

I've used the guide to create repo and link it to the git. And checks connection by commit and push using command pallete in obsidian. But automatically it doesn't work.

Expected Behavior

No response

Addition context

No response

Operating system

Windows

Installation Method

None

Plugin version

2.20.7

alexcmx commented 11 months ago

image This push I made manually

Vinzent03 commented 11 months ago

Sorry, but I couldn't understand what your issue exactly is. Please describe what exactly doesn't work and what you changed in the settings.

alexcmx commented 11 months ago

I think the problem is in image this setting. After switching it off. My vault commits and pushes correctly. But when it was switched on. Commits did't create automatically. Thank you)

Vinzent03 commented 11 months ago

That setting means, you have to edit a file and stop editing any file for 5 minutes for a new commit to happen. Did you wait 5 minutes after last edit and still no commit got created?

Mindstormer619 commented 10 months ago

Hey @Vinzent03, I'm unrelated to this issue, but got here googling to understand how this specific feature works -- does this mean that I should not be editing any file in the entire vault for the duration of the timeout?

My understanding was that it would prevent committing the current file under edit when the timeout struck, but would continue to add other files which got updated earlier but are not backed-up yet.

Vinzent03 commented 10 months ago

No, your first case is the case. You have to stop editing for the specified time duration any file in your entire vault.

DysphoricUnicorn commented 10 months ago

I feel like the wording of this could be improved quite a lot.

From reading the help text, I had assumed that this setting makes it so that obsidian always creates a backup instantly after I'm done editing a file (which would be quite useful behavior)

Maybe you could change it to something along the lines of "Do not auto backup while editing" to make this more clear