Deno version selection is broken

denolib / setup-deno

Set up your GitHub Actions workflow with a specific version of deno

https://github.com/marketplace/actions/setup-deno-environment

MIT License

181 stars 16 forks source link

Deno version selection is broken #42

Closed cj81499 closed 4 years ago

cj81499 commented 4 years ago

The usage examples show both v1.x, 1.0.0, and 0.42.0.

Can I use ^1.0.0 to get anything up to 2.0.0?

Is it preferable to include or leave off the "v"?

zhmushan commented 4 years ago

You can check the specific rules from node-semver, maybe we need to inform in the readme.

cj81499 commented 4 years ago

I just ran this (less than 5 minutes ago) in a private repository of mine. Based on caret ranges, I'd expect it to grab 1.1.1, but it grabs 1.0.0 instead.

Is this a bug or am I doing something wrong?

cj81499 commented 4 years ago

You can check the specific rules from node-semver, maybe we need to inform in the readme.

After fixing this bug, I think including this information in the readme would be very worthwhile.

axetroy commented 4 years ago

checkout to denolib/setup-deno@v2