Use original binary name for nightly builds?

[maximousblk]

I know I justified the use of name deno-nightly for the binary, but I think it would be better to use deno for the name so that it is easier to use with matrix configurations. And for the manual installers, we can rename the binary in the script itself.

Now the question is, should I do that? because this action is the major way of using these builds and this update will break all the workflows that are using the nightly builds from this action.

[maximousblk]

So I have decided to go with this change. The action itself won't break, just wanted to notify so you could update the docs.

also might wanna follow this: https://github.com/denoland/deno/issues/6974

cc @axetroy

[axetroy]

I think it would be better to use deno for the name so that it is easier to use with matrix configurations

We can use if: matrix.deno ==='nightly' to distinguish with stable version

Regarding whether to use deno or deno-nightly

I prefer deno, but BREAKING CHANGE updates are really annoying.

Of course, we can make a compatible, copy deno-nightly to deno and two executable files.

---

[maximousblk]

BREAKING CHANGE updates are really annoying.

Yes that is true but I don't think many people are using it for the time being.

We use it at nest.land which won't be a problem because I'm a maintainer there. Don't know about other projects.

But it's an easy fix and it won't affect the module consumers.

[maximousblk]

take a look at https://github.com/search?q=deno-nightly&type=Code only nest.land and my personal projects are using it.

[axetroy]

@maximousblk all right. LGTM.

@zhmushan How about this? We just need to rename deno-nightly file to deno.

[maximousblk]

do note that only the binary name is changing, not the zip file names. https://github.com/maximousblk/deno_nightly/pull/1

[axetroy]

do note that only the binary name is changing, not the zip file names. maximousblk/deno_nightly#1

If this is merged, this repo does not require any changes.

It will take effect after the nightly version is released the next day, because there is no renaming process, but directly unzip.

I only need to update the README at that time.

Good! 👍

EDIT:

oh! I thought you rename the binary file in the zip package to deno

[axetroy]

@maximousblk Could you trigger CI to release today's nightly build?

Because I am preparing to merge #60, But there is no nightly build exist, CI is always red now.

[maximousblk]

I have triggered the build process. I takes around 30 minutes on windows so you need to wait until then.

[zhmushan]

We just need to rename deno-nightly file to deno.

I agree

[maximousblk]

@axetroy build completed: https://github.com/maximousblk/deno_nightly/releases/tag/2020.08.07

[axetroy]

@maximousblk since v2.2.0 has been released.

now it should work with denolib/setup-deno@v2