search

denolib / typeorm

Forked from https://github.com/typeorm/typeorm
MIT License
117 stars 17 forks source link

Column decorator requires input #149

Open watzon opened 2 years ago

watzon commented 2 years ago

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

Deno version:

1.12.1

Steps to reproduce or a small repository showing the problem:

Create a model. The Column decorator must have at least one argument, forcing you to do Column({}) if you don't have any options to specify. Not the end of the world, but also an easy fix with one more overload or changing:

export function Column(options: ColumnOptions): Function;

to

export function Column(options?: ColumnOptions): Function;