denosaurs / wait

🌀 Minimal terminal spinner
https://deno.land/x/wait
MIT License
60 stars 5 forks source link

[BUG] Gittering cursor on Windows #3

Closed SteelAlloy closed 4 years ago

SteelAlloy commented 4 years ago

The cursor is not hidden on Windows, so the spinner is not very attractive. wait

eliassjogreen commented 4 years ago

I don't think hiding the cursor is possible on windows (but am not sure). This could also be a problem with certain terminals.

SteelAlloy commented 4 years ago

Hiding the cursor under Windows is possible (check cliffy dynamic prompts).

eliassjogreen commented 4 years ago

Actually it seems to not be enabled for windows for some reason (mod.ts:157). Ping @qu4k considering you wrote this and tty originally?

notfilippo commented 4 years ago

The windows limitation was already present in the original implementation (ora by sindre).

I don't have the means to test if this actually was a mistake and the feature is supported by windows natively. @oganexon If you find that's the case can you please open a pull?