missing the stabilization attribute 12 - Githubissues

denpamusic / homeassistant-plum-ecomax

Plum ecoMAX boiler controller integration for Home Assistant.

MIT License

30 stars 7 forks source link

missing the stabilization attribute 12 #39

Closed monique3838 closed 11 months ago

monique3838 commented 11 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

I want to suggest:

[X] support for a new product
[ ] new functionality for a product
[ ] documentation improvement
[ ] other

Feature description

unknown state instead of stabilization attribute 12 added

Webpage of the product, that I'm suggesting:

No response

My diagnostics data:

unknown state instead of stabilization attribute 12 added

Code of Conduct

[X] I agree to follow this project's Code of Conduct

denpamusic commented 11 months ago

Hi,

Thank you for the feedback!

Since I've already encountered difference in this specific state between different devices once, I believe it's best to let PyPlumIO handle normalization instead of adding more states in the integration. This has now been done in https://github.com/denpamusic/PyPlumIO/commit/46a0356d1d9658efc08a0ca47e0b817f7f21c3d5 and released as a part of v0.4.8.

The integration has also been updated to incorporate those changes in https://github.com/denpamusic/homeassistant-plum-ecomax/commit/9e135ad816f57d862c4af6f8cb5085210fab3ca4.