denpamusic / homeassistant-plum-ecomax

Plum ecoMAX boiler controller integration for Home Assistant.
MIT License
30 stars 7 forks source link

Ash pan level support for ecoMAX 860P3-S LITE #46

Closed dareksliwecki closed 10 months ago

dareksliwecki commented 10 months ago

Is there an existing issue for this?

I want to suggest:

Feature description

I use integration to communicate with the ecoMAX 860P3-S LITE controller. Using PyPlumIO library I discovered that frame 215 is responsible for reporting the level of filling ash pan. Is it possible to add entity support for this controller model?

Webpage of the product, that I'm suggesting:

No response

My diagnostics data:

No response

Code of Conduct

denpamusic commented 10 months ago

Hi,

Thank you very much for the feedback and research!

It's possible to add this sensor, although I will need diagnostics data from the integration in order to extract numerical model id for your controller. You can attach it via comments here or send it to denpa@denpa.pro.

denpamusic commented 10 months ago

Thanks for the diagnostics!

This has now been added as device-specific regdata sensor in this commit https://github.com/denpamusic/homeassistant-plum-ecomax/commit/cbf58c3877ae14c892449498976e5e1c6dac05ef.

Additionally, it seems that product IDs are only unique for base models, so EM860P-O and your EM860P-S, have exactly same ID 51 as they are both EM860P. To avoid collisions, I've redone the filter to work on full model string instead of product IDs.

You can now wait for a stable release or test it right now by installing the main branch!

Thanks again for your help!

dareksliwecki commented 10 months ago

Works great! Thanks for such quick update.

denpamusic commented 10 months ago

Thanks for such quick update.

You're welcome! Glad that everything works! Feel free to contact me if you need anything else added.