denpamusic / php-bitcoinrpc

Fully unit-tested Bitcoin JSON-RPC client based on GuzzleHttp.
MIT License
282 stars 100 forks source link

Different requirements in README.md and in composer.json #11

Closed vv12131415 closed 6 years ago

vv12131415 commented 6 years ago

in composer.json you have https://github.com/denpamusic/php-bitcoinrpc/blob/2e1cd8a33153c644f00d2d24fad896abfc394260/composer.json#L16 in README.md you have https://github.com/denpamusic/php-bitcoinrpc/blob/2e1cd8a33153c644f00d2d24fad896abfc394260/README.md#L16-L17

If 5.6 is not supported, then it should be dropped. Am I correct?

denpamusic commented 6 years ago

You're not wrong, as script developed with php 7 in mind. Once php 5.6 hit official End-of-Life, which will be on 2018-12-31 as stated here I'll also fully drop support for it in composer and CI (probably by creating new branch - v2.1.x re-implementing some things with nicer php7-only syntax)

For now my stance is that, if you want to use php 5.6, you still can but I won't provide support(as in technical support) in case something doesn't work. With that said travis CI configuration for this project still includes php 5.6, so it should be pretty safe to use, I just want to incentivize people to switch to php 7.

vv12131415 commented 6 years ago

Sure! Got it! 🙂

vv12131415 commented 6 years ago

Sure! Got it! 🙂