denscholar / RoR-group-project

0 stars 0 forks source link

Kanban board #7

Open ivaan1992 opened 2 years ago

ivaan1992 commented 2 years ago

For this capstone project, we are 2 students @denscholar & @ivaan1992 You can check our link clicking here

Gambit142 commented 2 years ago

Hi @ivaan1992 @denscholar 👋,

Good job so far!

Highlights

However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

image

image

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ivaan1992 commented 2 years ago

We made all changes that @Gambit142 marked!! Captura de pantalla de 2022-07-25 17-16-56

sja-thedude commented 2 years ago

Required Changes ♻️

Hi @ivaan1992 @Gambit142, This is @sja-thedude your code reviewer.

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

200w

Required Changes ♻️

https://user-images.githubusercontent.com/70269507/180885070-28ab6cdd-90a6-4295-a5fe-6587eb595655.mov

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ivaan1992 commented 2 years ago

We made the changes that @sja-thedude marked. Captura de pantalla de 2022-07-25 18-26-56

DammyShittu commented 2 years ago

Hi team,

APPROVED 🟢

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.