denschub / firefox-tabgroups

[UNMAINTAINED] A Firefox addon that provides tab grouping features similar to the removed TabView/TabGroups/Panorama features.
Other
147 stars 28 forks source link

Panel is not displayed correctly and unusable (crushed) #13

Closed etnbrd closed 8 years ago

etnbrd commented 8 years ago

Linux Arch 4.2.5-1-ARCH x86_64 GNU/Linux Firefox Nightly 45.0a1 (2015-11-14)

screenshot from 2015-11-25 11-13-31

denschub commented 8 years ago

Since I'm not able to reproduce this, I need some more information:

Thank you!

etnbrd commented 8 years ago

The panel never displayed correctly. I can scroll inside the crushed panel, see all the group tabs inside, and click on the group tabs. It works properly, except it is displayed improperly. In the browser console, I get an error when I click on the icon : TypeError: Property 'handleEvent' is not callable.

Thanks.

denschub commented 8 years ago

I see. I'm fairly confident that this is related to Bug 1224974 which means 2015-11-25 would be a working build. Would you mind giving it a try?

Edit: Oh wait, I just realized that you can scroll inside the panel. MIght I ask there the "TypeError: Property 'handleEvent' is not callable." error appears? There should be a file name and a line number on the right side. If it's truncated, mark the text and copy it and you'll have the full filename in your clipboard.

Also, I expect you're on the version published on AMO?

etnbrd commented 8 years ago

Nope, the bug is still present wiith Firefox-nightly 45.0a1 (2015-11-25) :(

denschub commented 8 years ago

Please address my other questions as well:

Edit: Oh wait, I just realized that you can scroll inside the panel. MIght I ask there the "TypeError: Property 'handleEvent' is not callable." error appears? There should be a file name and a line number on the right side. If it's truncated, mark the text and copy it and you'll have the full filename in your clipboard.

Also, I expect you're on the version published on AMO?

etnbrd commented 8 years ago

Now that I updated to 2015-11-25, I don't have the error anymore.

Yes, I installed it from AMO (addons.mozill.org).

I think I could fix the problem in the css, but I don't know exactly how firefox addons work. What is the process to update the css, and reinstall the modified plugin ?

p.s. sorry, I answered by mail, and I didn't get your edit.

Thanks,

Etienne.

denschub commented 8 years ago

The height is updated via an event that gets triggered within the panel and send out of the content script back to the addon. This is not a CSS fix.

Could you try reproducing this issue with a clean profile? Instructions for creating a new profile is available at support.mozilla.org. If you cannot reproduce it, please head over to about:support, click "copy raw data to clipboard" and send me an email to mail@dennis-schubert.de. Maybe, I'll be able to reproduce your issue with the same addons and settings you have.

If you still have this issue in a clean profile, I have to try to reproduce it somehow, which could get a bit hard.

Instructions for getting a customized copy of this add-on running is available in this projects README.md.

etnbrd commented 8 years ago

I cannot reproduce with a clean profile (It works). I tried to disable all the addons, in my current profile, and it still doesn't work. I send the raw data to your mail.

Thanks,

Etienne.

mnoorenberghe commented 8 years ago

I tried to disable all the addons, in my current profile, and it still doesn't work.

@etnbrd Do you have the pref nglayout.debug.disable_xul_cache set to true in your regular profile? If so, see if that happens if you revert it to the default of false. It seems to break some UI. See bug 1127744

etnbrd commented 8 years ago

Hi,

This pref doesn't appear in my config, so I guess it's not set. Moreover, as the addon was broken on my config, I switch to the official extension tabgroups.

On Tue, 8 Mar 2016 at 02:41 Matt N. notifications@github.com wrote:

I tried to disable all the addons, in my current profile, and it still doesn't work.

@etnbrd https://github.com/etnbrd Do you have the pref nglayout.debug.disable_xul_cache set to true in your regular profile? If so, see if that happens if you revert it to the default of false. It seems to break some UI. See bug 1127744 https://bugzilla.mozilla.org/show_bug.cgi?id=1127744

— Reply to this email directly or view it on GitHub https://github.com/denschub/firefox-tabgroups/issues/13#issuecomment-193548994 .

denschub commented 8 years ago

I'm closing this since apparently, nobody else is able to reproduce this. :/