denschub / firefox-tabgroups

[UNMAINTAINED] A Firefox addon that provides tab grouping features similar to the removed TabView/TabGroups/Panorama features.
Other
147 stars 28 forks source link

compatibility with Tab Groups add-on #14

Closed Quicksaver closed 8 years ago

Quicksaver commented 8 years ago

Hi Dennis,

I tweaked the sanity checks of stored data within my add-on. For instance, it rebuilds the groups bounds when this data is missing, so that it recognizes groups created by your add-on.

However this can only happen when the TabView frame is initialized. So whenever it makes any change to the groups, it has to deinitialize the frame first; hence this patch. :)

At least with this patch (and the latest dev build of my add-on, https://github.com/Quicksaver/Tab-Groups/releases/tag/v1b1) I can't reproduce the incompatibility case you described in one of your e-mails, about opening new tabs in different groups. I can create new groups, assign them tabs, and close groups from your button, and manage them correctly within my Tab Groups every step of the way.

Maybe this won't fix everything, but it definitely makes both add-ons usable at the same time. :)

denschub commented 8 years ago

Fair enough, thanks.