search

denschub / firefox-tabgroups

[UNMAINTAINED] A Firefox addon that provides tab grouping features similar to the removed TabView/TabGroups/Panorama features.
Other
147 stars 28 forks source link

#1 drag drop tabs between groups #31

Closed xiio closed 8 years ago

xiio commented 8 years ago

New feature allowing moving tabs between groups using drag&drop method

denschub commented 8 years ago

Could you please run ./node_modules/.bin/jake lint and make sure there are no code style issues? Your code heavily mixes tabs, spaces, camel case and snake case which makes everything rather hard to read.

Also, just for future reference, do never develop your features on the develop branch, but work in your own branch. That way, it is easier for you to keep up with changes to develop that may happen in the meantime - for example with the eslintrc-changes I just made to make it compatible with eslint 2.4.0...

xiio commented 8 years ago

When i ran eslint (2.4.0) i got a lot of errors. Should i use specific version of eslint? Sorry for inconvenient, but i'm quite novince with github repos contribution and jake and eslint.

Should i create new pull request from my new feature branch?